Document scripts as unmaintained#63
Open
ItsHarper wants to merge 2 commits intozedless-editor:mainfrom
Open
Conversation
Contributor
|
I'd rather just delete all of the scripts and reintroduce them from the newest upstream version when needed. We will probably never need a lot of them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
scriptfolder is a substantial amount of code that is most definitely being impacted by the Zedless changes, but is going completely untested, unreviewed, and unmaintained.This PR renames that folder to make the status of the scripts it contains clear. As we find need for various scripts there, we can individually opt to start maintaining specific ones by moving them back to a top-level
scriptfolder. This way, it's clear which scripts are safe (and the maintainers are responsible for keeping that way), and which ones might fuck up your shit.I also added a
README.mdfile to the renamed folder (click the link for a much more accurate rendering than the unified diff will give you). It recommends that if you need to use an unmaintained script, that you should first open a PR to move that script to thescriptfolder, giving us an opportunity to make any needed fixes to the script (either in-place as a one-off, or adopting it for ongoing maintenance by actually moving it to thescriptfolder) before they use it.